Improvements to MotorSubsystem#46
Merged
Merged
Conversation
kcooney
force-pushed
the
kcooney/motor-subsystem
branch
2 times, most recently
from
d089ee8 to
6c20c54
Compare
Collaborator
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
There was a problem hiding this comment.
Is there a reason you deprecated starting position?
kcooney
force-pushed
the
kcooney/motor-subsystem
branch
from
5f133ce to
ccac542
Compare
Contributor
Author
Chatted off-line with @cuttestkittensrule. The |
kcooney
force-pushed
the
kcooney/motor-subsystem
branch
3 times, most recently
from
c5ad791 to
39b00fa
Compare
Contributor
Author
Fixed. PTAL |
kcooney
force-pushed
the
kcooney/motor-subsystem
branch
from
39b00fa to
9e40dda
Compare
Contributor
Author
|
@cuttestkittensrule friendly ping |
kcooney
force-pushed
the
kcooney/motor-subsystem
branch
7 times, most recently
from
f6a837b to
7f449ac
Compare
kcooney
force-pushed
the
kcooney/motor-subsystem
branch
2 times, most recently
from
6f5dacf to
631fd7d
Compare
- Add `setSetpointCommand()` - Add `clampOutput()` protected method - Add `useOutput(double)` - Deprecate `useOutput(double, double)` - Remove `setpoint` field (instead, get from the controller) - Improve Javadoc
kcooney
force-pushed
the
kcooney/motor-subsystem
branch
from
631fd7d to
ac89ca8
Compare
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Oct 15, 2025
This includes the following: - Prospect-Robotics/lib2813#46 - Prospect-Robotics/lib2813#67 - Prospect-Robotics/lib2813#71 - Prospect-Robotics/lib2813#75 - Prospect-Robotics/lib2813#77 - Prospect-Robotics/lib2813#78 - Prospect-Robotics/lib2813#80 - Prospect-Robotics/lib2813#81 - Prospect-Robotics/lib2813#85
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Oct 15, 2025
This includes the following: - Prospect-Robotics/lib2813#46 - Prospect-Robotics/lib2813#67 - Prospect-Robotics/lib2813#71 - Prospect-Robotics/lib2813#75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disable()setSetpointCommand()clampOutput()protected methoduseOutput(double, double)setpointfield (instead, get from the controller)@Overrideannotations